search

cloudfleet / blimp-engineroom

The engine room manages the operations of all the services on a CloudFleet Blimp
GNU Affero General Public License v3.0
4 stars 2 forks source link

check_partitions.py needs to only exit with non-zero status when the encrypt routines should be run #2

Closed easye closed 8 years ago

easye commented 8 years ago

https://github.com/cloudfleet/blimp-engineroom/commit/633a66cda2bec90d3f523a0dcd5407d6c7c55a92 contains a failing test for the desired property.

easye commented 8 years ago

Partially fixed so that crypt setup should not run if check-partitions.py encounters an error https://github.com/cloudfleet/blimp-engineroom/commit/25b6b9f3743de893396ff7103c0907ee491d5a5a

TODO: fix the actual script

easye commented 8 years ago

Fixed in recent merges to master by re-write of underlying parse routines as well as wrapping in an exception correctly.

c.f. https://github.com/cloudfleet/blimp-engineroom/blob/8cfc42503c0c7f68b97fa0008d8306cd20c4ed52/bin/cryptpart/check_partitions.py