Closed nimakaviani closed 5 years ago
Hey nimakaviani!
Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.
I think this should all be rolled into #27
thought so too. but that PR is becoming really big. we can hold back on this and once #27 is merged, we can rebase this on master before merging.
rebased on master and fixed the Dockerfile
. seems to be the only thing that requires fixing after we pulled in the provision PR
Should we wait on this PR? since the dockerfile still needs docker to work?
yeah on the fence here. let's keep it around but we dont need to merge it for now.
confused the heck out of myself, but I think this is what we want to do?
ideally we want the docker container to have solc
and node
running on it too.
Does that all need to be done in this PR, right now? Is this not a step forward?
sounds good. let's fix it when we do another pass on this file.
add services as a volume to docker