update instructions on running the broker

cloudfoundry-attic / blockhead

CF-Extensions Blockhead project

Apache License 2.0

3 stars 3 forks source link

update instructions on running the broker #32

Closed nimakaviani closed 5 years ago

nimakaviani commented 5 years ago

add services directory as an input arg to the binary
add services as a volume to docker
- [x ] document your feature
- [x ] comment your code
- [ x] update the README / how-to-run

cfdreddbot commented 5 years ago

Hey nimakaviani!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

MHBauer commented 5 years ago

I think this should all be rolled into #27

nimakaviani commented 5 years ago

thought so too. but that PR is becoming really big. we can hold back on this and once #27 is merged, we can rebase this on master before merging.

nimakaviani commented 5 years ago

rebased on master and fixed the Dockerfile. seems to be the only thing that requires fixing after we pulled in the provision PR

swetharepakula commented 5 years ago

Should we wait on this PR? since the dockerfile still needs docker to work?

nimakaviani commented 5 years ago

yeah on the fence here. let's keep it around but we dont need to merge it for now.

MHBauer commented 5 years ago

confused the heck out of myself, but I think this is what we want to do?

nimakaviani commented 5 years ago

ideally we want the docker container to have solc and node running on it too.

MHBauer commented 5 years ago

Does that all need to be done in this PR, right now? Is this not a step forward?

nimakaviani commented 5 years ago

sounds good. let's fix it when we do another pass on this file.