Closed MHBauer closed 5 years ago
Hey MHBauer!
Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.
hopefully this resolves #38
I can split this up if that's wanted. What we really need is to make sure that each image for both geth nodes and the broker are fully working.
versions updated,
client-go image should always be a newer verison of geth, can float at >=v1 or try release-1.8
which should float with 1.8 releases
@nimakaviani everything is set and building? Can we merge?
sure looks good.
Ideally we would like to tag the images we build in the Makefile as blockheads/broker
and blockheads/geth-node
but we can fix that later.
I created a repo for blockheads
on dockerhub (blockhead
- singular - was taken).
broker image has node:alpine and js libs
geth-node uses upstream client-go image with our customizations
[x] document your feature (added to readme)
[ ] comment your code
[x] update the README / how-to-run
[x] have tests (make changes are automatically run by travis)
[ ] get reviews in slack