cloudfoundry-attic / bosh-init

bosh-init is a tool used to create and update the Director VM
Apache License 2.0
31 stars 33 forks source link

Need to check err before next step in bosh-init/installation/installer.go. #37

Closed AbelHu closed 9 years ago

AbelHu commented 9 years ago

bosh-init/installation/installer.go: func (i *installer) Install(manifest biinstallmanifest.Manifest, stage biui.Stage) (Installation, error) { ... renderedJobRefs, err := i.jobRenderer.RenderAndUploadFrom(manifest, jobs, stage) ///////////////////////////////////////////// Issue: Need to check err before next step. ///////////////////////////////////////////// renderedCPIJob := renderedJobRefs[0] installedJob, err := i.installJob(renderedCPIJob, stage)

Error log: [Main] 2015/06/17 08:10:28 ERROR - Panic: runtime error: index out of range


/home/abelch/.go/src/github.com/cloudfoundry/bosh-init/Godeps/_workspace/src/github.com/cloudfoundry/bosh-utils/logger/logger.go:134 (0x455471) /usr/local/go/src/pkg/runtime/panic.c:248 (0x40fd9d) /usr/local/go/src/pkg/runtime/panic.c:552 (0x41084d) /usr/local/go/src/pkg/runtime/panic.c:466 (0x410547) /home/abelch/.go/src/github.com/cloudfoundry/bosh-init/installation/installer.go:87 (0x4b6c14) /home/abelch/.go/src/github.com/cloudfoundry/bosh-init/cpi/release/installer.go:37 (0x4b069b) /home/abelch/.go/src/github.com/cloudfoundry/bosh-init/ui/stage.go:65 (0x4639b6) /home/abelch/.go/src/github.com/cloudfoundry/bosh-init/cpi/release/installer.go:39 (0x4afbe5) /home/abelch/.go/src/github.com/cloudfoundry/bosh-init/cpi/release/installer.go:48 (0x4afd4d) /home/abelch/.go/src/github.com/cloudfoundry/bosh-init/cmd/deployment_preparer.go:176 (0x442680) /home/abelch/.go/src/github.com/cloudfoundry/bosh-init/cmd/deploy_cmd.go:74 (0x440428) /home/abelch/.go/src/github.com/cloudfoundry/bosh-init/cmd/runner.go:27 (0x44bb8e) /home/abelch/.go/src/github.com/cloudfoundry/bosh-init/main.go:42 (0x401244) /usr/local/go/src/pkg/runtime/proc.c:247 (0x411dfa) /usr/local/go/src/pkg/runtime/proc.c:1445 (0x4145c0)


AbelHu commented 9 years ago

Duplicated as https://github.com/cloudfoundry/bosh-init/issues/36.