search

cloudfoundry-attic / bosh-init

bosh-init is a tool used to create and update the Director VM
Apache License 2.0
31 stars 33 forks source link

fix the cid is not string data type issue #43

Closed ghost closed 8 years ago

ghost commented 8 years ago

Dear, According the Go JSON Unmarshal func API Doc The JSON numbers should be float64 , not string type . So, need to do date type conversation.

cfdreddbot commented 8 years ago

Hey wen-quan!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

ghost commented 8 years ago

Current behavior is correct. http://bosh.io/docs/cpi-api-v1.html#create-vm contract states that's it's an opaque string. It's just happens that softlayer CPI returns only numeric values; however, most CPIs return non numeric IDs.

Sent from my iPhone

On Aug 31, 2015, at 7:02 PM, Quan Wen notifications@github.com wrote:

Dear, According the Go JSON Unmarshal func API Doc The JSON numbers should be float64 , not sting type . So, need to do date type conversation.

You can view, comment on, or merge this pull request online at:

https://github.com/cloudfoundry/bosh-init/pull/43

Commit Summary

fix the cid is not string data type issue File Changes

M cloud/cloud.go (27) Patch Links:

https://github.com/cloudfoundry/bosh-init/pull/43.patch https://github.com/cloudfoundry/bosh-init/pull/43.diff — Reply to this email directly or view it on GitHub.