cloudfoundry-attic / bosh-init

bosh-init is a tool used to create and update the Director VM
Apache License 2.0
31 stars 33 forks source link

Add pre-built binaries as GitHub Release Artifacts #79

Open geofffranks opened 8 years ago

geofffranks commented 8 years ago

Can the distributed versions of bosh-init (from https://s3.amazonaws.com/bosh-init-artifacts/*) be added to the github releases for bosh-init, to make it easy for people to trigger jobs to update environments based on new releases of bosh-init via Concourse?

cppforlife commented 8 years ago

any reason not to use s3 resource?

Sent from my iPhone

On Jun 3, 2016, at 8:11 AM, Geoff Franks notifications@github.com wrote:

Can the distributed versions of bosh-init (from https://s3.amazonaws.com/bosh-init-artifacts/*) be added to the github releases for bosh-init, to make it easy for people to trigger jobs to update environments based on new releases of bosh-init via Concourse?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

geofffranks commented 8 years ago

We have a number of other things using the GitHub resource, which includes the version file, indicating what version of the binary was released. The artifacts all end up having the same name, which makes it easier to implement/consume, rather than check the s3 bucket for new binaries of later versions, and parse that out.

I guess we could use a combo of both, and pull the version from one the github-release resource, and the binary from the s3 resource, but that seems more clunky to support than having them all in a single resource.

On Jun 3, 2016, at 11:24 AM, Dmitriy Kalinin notifications@github.com wrote:

any reason not to use s3 resource?

Sent from my iPhone

On Jun 3, 2016, at 8:11 AM, Geoff Franks notifications@github.com wrote:

Can the distributed versions of bosh-init (from https://s3.amazonaws.com/bosh-init-artifacts/*) be added to the github releases for bosh-init, to make it easy for people to trigger jobs to update environments based on new releases of bosh-init via Concourse?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cloudfoundry/bosh-init/issues/79#issuecomment-223609876, or mute the thread https://github.com/notifications/unsubscribe/AG2SUgFpsH1DPVd2-nGJp7XMQn6kWtb5ks5qIEdHgaJpZM4ItoMV.

cppforlife commented 8 years ago

might also make sense to add a feature to s3 resource to pick up named regex matches and have them to be files. that way you can match version and version file will be present. cc @vito

joek commented 8 years ago

+1 We are using bosh-init inside a Docker container. Making the files part of the release would make it much easier to pull them as soon as a new Release is available.

Do you like to have an pull request? It should be easy to just add the globs to the git release inside the concourse pipeline.

drnic commented 8 years ago

Dmitriy/Someone, perhaps add a sample of concourse pipeline YAML to the README on how ppl can detect & pull new s3-resource versions and get the semver into a version file?

For anyone wanting to add this, look at https://github.com/concourse/s3-resource#in-fetch-an-object-from-the-bucket to see reference to version file auto-created (based on the regexp https://github.com/concourse/s3-resource#file-names)

drnic commented 8 years ago

An example is in http://concourse.ci/versioned-s3-artifacts.html

cppforlife commented 8 years ago

all right, lets go for the PR and we ll merge it.

Sent from my iPhone

On Jun 20, 2016, at 2:00 AM, Dr Nic Williams notifications@github.com wrote:

An example is in http://concourse.ci/versioned-s3-artifacts.html

  • name: my-product-rc type: s3 source: bucket: my-product-pipeline-artifacts regexp: my-product-(.*).tgz access_key_id: {{s3-access-key-id}} secret_access_key: {{s3-secret-access-key}} — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.