Closed dpb587 closed 7 years ago
Hey dpb587!
Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.
@dpb587 i like it! though we already added BOSH_ENVIRONMENT, mind changing commit to only do BOSH_DEPLOYMENT?
Just as a side comment: Usually deployment names don't have the -release
, i.e. it is called cf
, not cf-release
: https://github.com/cloudfoundry/cf-release/blob/master/example_manifests/minimal-aws.yml#L4
And I guess it is even worse than I thought with the bosh-lite deployment being named cf-warden
So using the directory name sounds interesting, but will lead to something entirely different than what people do today.
@voelzmo that's just an example. .envrc would be in your repo so you can hard code it to whatever you want (i would recommend hardcoding it). cli change is only BOSH_DEPLOYMENT env.
Rebased/changed. Yeah, cf-release
was an odd example; oops.
Generically, for things like
.envrc
...What do you think?