search

cloudfoundry-attic / bosh-lite

A lite development env for BOSH
Apache License 2.0
319 stars 245 forks source link

Add downloaded bosh lite stemcell to gitignore #425

Closed dlresende closed 7 years ago

dlresende commented 7 years ago

The process of installing a bosh-lite + cf requires a bosh-lite stemcell to be downloaded. At the end of the process, my local git repository reported some changes:

± dlr |master ?:1 ✗| → git status
On branch master
Your branch is up-to-date with 'origin/master'.
Untracked files:
  (use "git add <file>..." to include in what will be committed)

        latest-bosh-lite-stemcell-warden.tgz

nothing added to commit but untracked files present (use "git add" to track)

This PR adds the downloaded latest-bosh-lite-stemcell-warden.tgz to gitignore.

cfdreddbot commented 7 years ago

Hey dlresende!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

dlresende commented 7 years ago

Hey,

I did publicize my membership of pivotal-cf org.

As per my understanding, that should be enough.

dpb587-pivotal commented 7 years ago

Thanks for the PR - can you clarify how you got a file named latest-bosh*-stemcell-warden.*? Nowadays, bosh.io should be giving names in a very predictable format of bosh-stemcell-*-warden-boshlite-ubuntu-trusty-go_agent.tgz, so I don't think the .gitignore should need to change. Hoping you can point us to a doc that we can update instead.

dlresende commented 7 years ago

Actually I'm using the bin/provision_cf script. That script is downloading the lite stemcell locally with a name which currently is not compatible with with the name in the gitignore.

Updating the gitignore seems to be the change with less impact to sort it out.

dpb587-pivotal commented 7 years ago

Fair enough - thanks for the links.

For what it's worth, we're trying to encourage people to start using bosh-deployment, and, specifically, the bosh-lite ops file there. If you get a chance, you might want to try that out.