CPI script bails on error

cloudfoundry-attic / bosh-softlayer-cpi-release-DEPRECATED-TO_BE_DELETED

A BOSH release for the bosh-softlayer-cpi written in Golang and using the new BOSH external CPI release fashion.

Apache License 2.0

3 stars 8 forks source link

CPI script bails on error #33

Closed cunnie closed 8 years ago

cunnie commented 8 years ago

The CPI script as it stands shouldn't ever error-out; this PR is merely about laying the groundwork for the future if the script becomes more complicated (e.g. passing in environment variables such as HTTPS_PROXY) -- we'd want the script to abort as soon as it encountered an error (we chased down a bug in the vSphere CPI which was caused partly by the CPI script not aborting).

#128097379

Signed-off-by: Brian Cunnie bcunnie@pivotal.io

cfdreddbot commented 8 years ago

Hey cunnie!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

maximilien commented 8 years ago

OK, thanks. I'll merge this now.

/cc @mattcui @jianqiu @gu-bin