search

cloudfoundry-attic / bosh-softlayer-cpi-release-DEPRECATED-TO_BE_DELETED

A BOSH release for the bosh-softlayer-cpi written in Golang and using the new BOSH external CPI release fashion.
Apache License 2.0
3 stars 8 forks source link

Make it possible use this release on macOS #36

Closed petergtz closed 7 years ago

petergtz commented 7 years ago

Addresses https://github.com/cloudfoundry/bosh-softlayer-cpi/issues/148.

Note:

  1. https://github.com/cloudfoundry/bosh-softlayer-cpi/pull/189 needs to be merged first.
  2. https://storage.googleapis.com/golang/go1.7.1.darwin-amd64.tar.gz needs to be available in the blobstore (see packages/golang_1.7.1/spec below).
cfdreddbot commented 7 years ago

Hey petergtz!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

maximilien commented 7 years ago

Thanks for the submission @petergtz.

@zhanggbj same deal. Please review and ensure this passes pipeline and we can merge.

Thanks,

Max

maximilien commented 7 years ago

@zhanggbj please ping me offline on the new pipeline info so I can check or please let me know if you check and I can merge this. Thanks.

zhanggbj commented 7 years ago

Hi Dr.Max @maximilien ，

I'll run the pipeline and paste the result here. Thanks.

maximilien commented 7 years ago

Thanks @zhanggbj

maximilien commented 7 years ago

Oh also, just noticed that with this project we don't have auto testing setup. We simply need to have a .travis.yml file like the CPI project and others. Let's make sure this is added here.

make_it_possible_use_this_release_on_macos_by_petergtz_ _pull_request__36_ _cloudfoundry-incubator_bosh-softlayer-cpi-release

/cc @zhanggbj