search

cloudfoundry-attic / bosh-vcloud-cpi-release

BOSH vCloud CPI
Apache License 2.0
4 stars 11 forks source link

Handle old failed tasks on vCloud Entities #11

Closed tlawrence closed 8 years ago

tlawrence commented 8 years ago

vCloud maintains a list of historical tasks for a vApp. These tasks are returned in the Xml element of a GET vAPP response. When BOSH recomposes a vApp (to merge in new VMs for example) currently it aborts the BOSH Task if any failed tasks are identified. This PR enables a configurable time threshold @old_task_threshold which tells the vcd_client library to disregard tasks older than the value (in minutes). By default tasks older than an hour will be ignored.

This is an update version of: https://github.com/cloudfoundry-attic/bosh_vcloud_cpi/pull/18

and relates to issue #10

cfdreddbot commented 8 years ago

Hey tlawrence!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cppforlife commented 8 years ago

thank you for refiling the pr so quickly. ill update the other repo with a deprecated notice (or may be even delete it, its been sitting inthe attic org for long time). we ll get to this pr this coming morning. i do see though that dreddbot is not finding cla on file. please follow its instructions and submit a cla so that we can merge this.

Sent from my iPhone

On May 13, 2016, at 2:54 AM, Tim Lawrence notifications@github.com wrote:

vCloud maintains a list of historical tasks for a vApp. These tasks are returned in the Xml element of a GET vAPP response. When BOSH recomposes a vApp (to merge in new VMs for example) currently it aborts the BOSH Task if any failed tasks are identified. This PR enables a configurable time threshold @old_task_threshold which tells the vcd_client library to disregard tasks older than the value (in minutes). By default tasks older than an hour will be ignored.

This is an update version of: cloudfoundry-attic/bosh_vcloud_cpi#18

and relates to issue #10

You can view, comment on, or merge this pull request online at:

https://github.com/cloudfoundry-incubator/bosh-vcloud-cpi-release/pull/11

Commit Summary

OLD_TASK_THRESHOLD With Updated Specs tidy up Gemfile.lock File Changes

D src/bosh_vcloud_cpi/Gemfile.lock (95) M src/bosh_vcloud_cpi/lib/cloud/vcloud/vcd_client.rb (40) M src/bosh_vcloud_cpi/lib/cloud/vcloud/xml/wrapper_classes/task.rb (4) M src/bosh_vcloud_cpi/spec/assets/test-director-config.yml (1) M src/bosh_vcloud_cpi/spec/unit/vcloud/vcd_client_spec.rb (40) A src/bosh_vcloud_cpi/spec/unit/vcloud/xml/task_spec.rb (30) Patch Links:

https://github.com/cloudfoundry-incubator/bosh-vcloud-cpi-release/pull/11.patch https://github.com/cloudfoundry-incubator/bosh-vcloud-cpi-release/pull/11.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

tlawrence commented 8 years ago

our commercial Director is sending the CLA this afternoon.

tlawrence commented 8 years ago

Chip has authorised our CLA now.

cppforlife commented 8 years ago

Available in v21.