search

cloudfoundry-attic / bosh-vcloud-cpi-release

BOSH vCloud CPI
Apache License 2.0
4 stars 11 forks source link

Unexposed vcd client retry parameters #4

Open cromega opened 8 years ago

cromega commented 8 years ago

While we were coding the previous PR we noticed that the retry parameters in the VCD client were not exposed in the cpi job spec (retry_max, retry_delay).

We thought about making some changes to make these values configurable as right now they are hard-coded (10, 20), but we were confused by some parts of the code. There seem to be nested retries (one level in cloud.rb, the other one the send_request method in vcd_client.rb). There are comments in the code that suggest that those parts of the cpi are going to be refactored.

In order to optimise our BOSH configuration and see what settings result in the quickest successful deploy, we would like to play around with these values.

cppforlife commented 8 years ago

Can you please provide stack traces you have seen when actions time out?

Sent from my iPhone

On Sep 7, 2015, at 9:35 AM, Bence Monus notifications@github.com wrote:

While we were coding the previous PR we noticed that the retry parameters in the VCD client were not exposed in the cpi job spec (retry_max, retry_delay).

We thought about making some changes to make these values configurable as right now they are hard-coded (10, 20), but we were confused by some parts of the code. There seem to be nested retries (one level in cloud.rb, the other one the send_request method in vcd_client.rb). There are comments in the code that suggest that those parts of the cpi are going to be refactored.

In order to optimise our BOSH configuration and see what settings result in the quickest successful deploy, we would like to play around with these values.

— Reply to this email directly or view it on GitHub.