search

cloudfoundry-attic / bosh-workspace

Gem for managing your bosh workspace
MIT License
22 stars 26 forks source link

Stemcell upload #85

Closed sklevenz closed 8 years ago

sklevenz commented 8 years ago

proposed patch for issue number #84

the first commit adds the new functionality, the second commit cleans up the no longer needed methods for locally downloading stemcells.

cfdreddbot commented 8 years ago

Hey sklevenz!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

rkoster commented 8 years ago

There is one important use case which is not covered by this PR. Which is bosh prepare deployment --local Which works in environments without internet access. It assumes the needed stemcell is already available in .stemcells. Maybe there should be and option to force stemcells to be cached locally: bosh prepare deployment --cache-locally? Let met know what you think.

sklevenz commented 8 years ago

--cache-locally sounds good. I am going to provide another commit for this PR. Thanks.

allomov commented 8 years ago

I also support --cache-locally.

I guess it would be also nice to have ability to download stemcells from custom URL or setting path to stemcell file. For instance at the moment I have to do so for Power stemcells. What do you think?

sklevenz commented 8 years ago

@allomov This sounds like a feature request which I would support, too. I have provided a 2nd pull request to fix the issue only. So this PR is abandoned and I close it.