search

cloudfoundry-attic / cf-abacus

CF usage metering and aggregation
Apache License 2.0
98 stars 86 forks source link

Collector - return 'bad request' in case account or provisioning plugin returns 'not found' #1136

Closed martin-d-aleksandrov closed 5 years ago

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/162444609

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 5 years ago

:white_check_mark: Hey martin-d-aleksandrov! The commit authors and yourself have already signed the CLA.

codecov[bot] commented 5 years ago

Codecov Report

Merging #1136 into master will decrease coverage by 0.34%. The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1136      +/-   ##
==========================================
- Coverage   95.22%   94.88%   -0.35%     
==========================================
  Files         126      127       +1     
  Lines        3479     3477       -2     
==========================================
- Hits         3313     3299      -14     
- Misses        166      178      +12
Impacted Files Coverage Δ
lib/utils/api/src/lib/clients/collector-client.js 100% <100%> (ø) :arrow_up:
lib/utils/api/src/lib/clients/reporting-client.js 100% <100%> (ø) :arrow_up:
lib/metering/collector/src/lib/usage-validator.js 100% <100%> (ø) :arrow_up:
lib/utils/api/src/lib/clients/receiver-client.js 100% <100%> (ø) :arrow_up:
...tils/api/src/lib/clients/service-mapping-client.js 100% <100%> (ø) :arrow_up:
lib/utils/api/src/lib/clients/webapp-client.js 100% <100%> (ø) :arrow_up:
lib/metering/collector/src/lib/collector.js 86.2% <75%> (-13.8%) :arrow_down:
lib/utils/api/src/lib/request-strategy.js 80% <80%> (ø)
lib/utils/rabbitmq/src/lib/connection-manager.js 76% <81.81%> (-5.82%) :arrow_down:
...b/utils/api/src/lib/clients/provisioning-client.js 91.83% <95.23%> (-8.17%) :arrow_down:
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf49fa1...3aeec21. Read the comment docs.