cloudfoundry-attic / cfdev

A fast and easy local Cloud Foundry experience on native hypervisors, powered by LinuxKit with VPNKit
Apache License 2.0
227 stars 64 forks source link

CFDEV fail to start on Windows with conflicting Powershell modules installed #111

Closed shouah closed 5 years ago

shouah commented 5 years ago

Summary: When running CFDEV on Windows 10 which has powershell modules for both Hyper-V and VMware PowerCLI installed, which has duplicated commands like Get-VM, then then CF CLI plugin invokes the wrong command and fails unexpectedly.

Expected behavior: The command "cf dev start -f ...tgz" invokes the correct PowerShell commands under the hood

Observed behavior:

> cf dev start -f .\pcfdev-v1.2.0-windows.tgz
FAILED
cf dev start: is running: getting vms: failed to execute: powershell.exe -Command "Get-VM -Name cfdev*": exit status 1: Get-VM : 8/20/2019 10:33:14 AMGet-VM          You are not currently connected to any servers. Please connect first using a Connect cmdlet.
At line:1 char:1
+ Get-VM -Name cfdev*
+ ~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : ResourceUnavailable: (:) [Get-VM], ViServerConnectionException
    + FullyQualifiedErrorId : Core_BaseCmdlet_NotConnectedError,VMware.VimAutomation.ViCore.Cmdlets.Commands.GetVM

Request: Either:

  1. Update the plugin to explicitly prefix all PowerShell commands with the Hyper-V prefix to ensure ambiguous execution, for example:

powershell.exe -Command "Hyper-V\Get-VM -Name cfdev*"

  1. Or provide a start command line option to specify the PowerShell prefix to be used, something like:

cf dev start -f ...tgz -psprefix "Hyper-V"

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/168005551

The labels on this github issue will be updated when the story is started.

aemengo commented 5 years ago

Apologies for the lack of response on this issue, up until now. Your request is sound and is a use-case that we'd like to support. We opted for option 1.

  1. Update the plugin to explicitly prefix all PowerShell commands with the Hyper-V prefix to ensure ambiguous execution

The code fix should be applied and present in our most recent CLI release: 0.0.17.

$ cf install-plugin -r CF-Community cfdev
...
$ cf dev version
CLI: 0.0.17
BUILD: 14 (b36c82e)

Many thanks for bringing this to our attention.