cloudfoundry-attic / cfdev

A fast and easy local Cloud Foundry experience on native hypervisors, powered by LinuxKit with VPNKit

Apache License 2.0

227 stars 64 forks source link

Improve code quality in start command #89

Open NickyMateev opened 5 years ago

NickyMateev commented 5 years ago

Improve code quality in start command

While searching in the code a little bit, I noticed a few places where there was unnecessary branching of conditional statements, which were mutually exclusive.

In my opinion the code is more clear with the proposed change.

cfdreddbot commented 5 years ago

:x: Hey NickyMateev!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA). Click here for details on the CLA process.

The following github user @NickyMateev is not covered by a CLA.

After the CLA process is complete, this pull request will need to be closed & reopened. DreddBot will then validate the CLA(s).

cf-gitbot commented 5 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/165589911

The labels on this github issue will be updated when the story is started.

aemengo commented 5 years ago

Hey thanks for the contribution. I definitely agree with your line of thinking here.

If you get the CLA signed, we'll pull this commit right in.

NickyMateev commented 5 years ago

Hey, as an employee of SAP I know that our company has already signed the CLOUDFOUNDRY.ORG FOUNDATION SOFTWARE GRANT AND CORPORATE CONTRIBUTOR LICENSE AGREEMENT (CCLA).

Is there anything additional I need to do?

aemengo commented 5 years ago

The CLA instructions say to give the following a shot: https://help.github.com/en/articles/publicizing-or-hiding-organization-membership. And then resubmit the PR.

NickyMateev commented 5 years ago

I've actually publicized my organization membership a long time ago (it's been at least a year since I did it), so that's something I've already done.