search

cloudfoundry-attic / cloud-controller-stager

Stager for Cloud Foundry
Apache License 2.0
3 stars 14 forks source link

remove docker caching logic from docker backend #15

Closed jfmyers9 closed 7 years ago

jfmyers9 commented 7 years ago

[#133638427]

Signed-off-by: James Myers jmyers@pivotal.io

cfdreddbot commented 7 years ago

Hey jfmyers9!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/134614259

The labels on this github issue will be updated when the story is started.

Gerg commented 7 years ago

Hey @jfmyers9,

Thanks for the PR. Since the bridge components have changed how they consume their config, this PR was a bit stale.

emalm commented 7 years ago

@Gerg || @aashah: Should the Diego team resubmit this PR to reflect those config changes? Are those config changes related to https://www.pivotaltracker.com/story/show/134608685? We'd appreciate more information than just your closing the PR for something that sounds pretty trivial. /cc @SocalNick @utako

Thanks, Eric

emalm commented 7 years ago

Oh, I see, https://github.com/cloudfoundry/stager/commit/9e63d982bb5526a7e202a0d591f7de363c5c0e5d reworks this PR. In future, please refer to such a commit manually in your communication about closing the PR, or use commit message syntax such as "closes #15" to have GitHub automatically close the PR with a reference to the commit.

Thanks, Eric

Gerg commented 7 years ago

Sorry for the confusion, Eric. We tagged the PR in the commit, but we didn't consider what it would look like for people following the thread.

emalm commented 7 years ago

Thanks, @Gerg, not a big deal. I also didn't see your commit tag in the gitbot relabeling and cf-tm-bot reference noise.

Best, Eric