search

cloudfoundry-attic / consul-release

This is a BOSH release for consul.
Apache License 2.0
10 stars 30 forks source link

Why does consul-agent not allow to set DNS caching? #26

Closed AbelHu closed 8 years ago

AbelHu commented 8 years ago

From DNS caching, we know that consul allows to configure dns_config.allow_stale and dns_config.max_stale for performance and scalability. But in the configure of consul-agent, we found no settings for DNS caching. What is the reason for that?

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/122175811

The labels on this github issue will be updated when the story is started.

Amit-PivotalLabs commented 8 years ago

Hi @AbelHu

Sorry for the delayed response.

There's no particular reason for these properties to not be exposed, except perhaps for keeping the interface for this release slim and only exposing crucially important properties. Exposing the properties you mentioned is not a priority at this time, but we'd welcome a pull request. If you're interested in submitting a PR for this feature, be sure to check out the contributing instructions.

If you were to do this, I would expose this via job spec properties on the consul_agent job called consul.dns_config.max_stale and consul.dns_config.max_stale.

AbelHu commented 8 years ago

@Amit-PivotalLabs Thanks for your response. We will consider to submit a PR later.

keymon commented 8 years ago

@AbelHu Hi, are you considering do a PR for this?

Amit-PivotalLabs commented 8 years ago

@keymon @AbelHu FYI: https://www.pivotaltracker.com/story/show/126916281