search

cloudfoundry-attic / consul-release

This is a BOSH release for consul.
Apache License 2.0
10 stars 30 forks source link

Basic Windows support #43

Closed benmoss closed 8 years ago

benmoss commented 8 years ago

Hey all,

Here's our latest attempt at Windows support for Confab. We would like to discuss how to add something to the CONSATs as well, but as far as we can tell it would only be able to run on non-Lite directors, since it requires a different OS.

The exiter stuff you see is there because our packaging scripts are written in Powershell and therefore don't work with bosh export release, which tries to build all the packages for a single stemcell. We figured out this trick so that they can run in bash and short-circuit, producing an empty pre-compiled package. Since we don't actually run these jobs on Linux this isn't a problem.

Amin & Ben

cfdreddbot commented 8 years ago

Hey benmoss!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/129882983

The labels on this github issue will be updated when the story is started.

aminjam commented 8 years ago

We added golang/go1.6.3.windows-amd64.zip as a blob, which is available here: https://storage.googleapis.com/golang/go1.6.3.windows-amd64.zip

Amit-PivotalLabs commented 8 years ago

Looks like this would also need config/blobs.yml updates, but I can see why that wouldn't be part of this PR since you won't have creds to upload to the bucket.

Amit-PivotalLabs commented 8 years ago

We would like to discuss how to add something to the CONSATs as well, but as far as we can tell it would only be able to run on non-Lite directors, since it requires a different OS.

Sounds reasonable. CONSATS_CONFIG could have

  UseWindowsAgents bool `json:"use_windows_agents"`

field and the manifest generation in destiny could determine the stemcell and templates to use for the client jobs. This would probably require test-consumer to be ported to windows as well.

Amit-PivotalLabs commented 8 years ago
Amit-PivotalLabs commented 8 years ago

Hey @aminjam if you could either fix this PR or create stories to address the remaining points above, we can prioritize this PR.

aminjam commented 8 years ago

Added a story for CONSATs here: https://www.pivotaltracker.com/story/show/130237483

aminjam commented 8 years ago

@Amit-PivotalLabs Is there anything else you need from us for this PR? We have already started the work on the other stories.

christianang commented 8 years ago

Hi @benmoss,

Can you rebase one more time to get this PR up to date with the latest develop. We have finished the dns epic and are in a state where we can merge this PR, however there are a few changes that need to be made before we can do so. First is updating the windows package to use consul 0.7. We also are no longer using dnsmasq. This means we are setting consul's port to 53 again and that is set in confab. If you can get those two things in sync we can merge this PR right away.

Thanks, Christian and @chinangela

aminjam commented 8 years ago

@christianang We have rebased this PR with develop, and updated the consul to 0.7.0. We are unable to upload the blobs, so these are the expected blobs for this PR:

consul-windows/consul_0.7.0_windows_amd64.zip golang/go1.6.3.windows-amd64.zip

Amin & Sunjay

christianang commented 8 years ago

Cool thanks for updating that. We have also added those two blobs to consul-release.

Christian & @evanfarrar

sunjayBhatia commented 8 years ago

@Amit-PivotalLabs We just submitted a PR for the monit stop feature (requested here)