cloudfoundry-attic / consul-release

This is a BOSH release for consul.
Apache License 2.0
10 stars 30 forks source link

Add syslog to consul_agent_windows #52

Closed aminjam closed 7 years ago

aminjam commented 7 years ago

A/C: As an operator I should be able to see logs from consul in syslog destination syslog_daemon_config defined in my cf manifest.

The support for the new environment variables has been added to AWS stemcell version 0.0.73 and above.

[#133698951] https://www.pivotaltracker.com/story/show/133698951

Signed-off-by: Sunjay Bhatia sbhatia@pivotal.io Signed-off-by: Amin Jamali ajamali@pivotal.io Signed-off-by: Natalie Arellano narellano@pivotal.io

cfdreddbot commented 7 years ago

Hey aminjam!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/134278591

The labels on this github issue will be updated when the story is started.

mavenraven commented 7 years ago

hey @zankich @christianang, any thoughts on this pr? thanks!

zankich commented 7 years ago

@mavenraven sorry for the delayed response, this PR has been prioritized

charlievieth commented 7 years ago

@zankich We have an additional small change to the error handling of the powershell scripts https://github.com/greenhouse-org/consul-release/commit/5844d8e5f5aa498bd7d743e032c9cbfd595e661e - would it be ok to append it to this PR or would you like for us to create another.

It simplifies and fixes some issues with the way error handling was previously performed and most of the code changes are the removal of try...catch blocks.

mavenraven commented 7 years ago

thanks @zankich !

sunjayBhatia commented 7 years ago

@zankich any updates on if you want us to add the additional powershell changes to this PR or to a new PR? Thanks!

evanfarrar commented 7 years ago

@sunjayBhatia merged, sorry for the delay.

mavenraven commented 7 years ago

thanks @evanfarrar