Fix powershell error handling and exit code.

cloudfoundry-attic / consul-release

This is a BOSH release for consul.

Apache License 2.0

10 stars 30 forks source link

Fix powershell error handling and exit code. #53

Closed sunjayBhatia closed 7 years ago

sunjayBhatia commented 7 years ago

Stop script execution on error and return a non-zero exit code. Previously, PowerShell happily plowed through errors with little regard for traps, try catch blocks or the non-zero exits within them.

[#134462851]

cfdreddbot commented 7 years ago

Hey sunjayBhatia!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/135659433

The labels on this github issue will be updated when the story is started.

aminjam commented 7 years ago

@christianang The second commit in this PR is required to run consul_agent_windows on GCP.

jtarchie commented 7 years ago

Please pull this in. This worked perfectly for us when deploying Windows cells on GCP.

angelachin commented 7 years ago

Thanks! 🍉

@christianang and Angela