cloudfoundry-attic / consul-release

This is a BOSH release for consul.
Apache License 2.0
10 stars 30 forks source link

Add `require_ssl` property to secure local agent #59

Closed sunjayBhatia closed 7 years ago

sunjayBhatia commented 7 years ago

This PR adds a property to the consul_agent_windows job to require SSL when communicating over localhost. The HTTP port is disabled when this property is specified and the HTTPS port is set to 8500.

The requisite unit tests pass on *nix and Windows.

cfdreddbot commented 7 years ago

Hey sunjayBhatia!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/136796693

The labels on this github issue will be updated when the story is started.

kkallday commented 7 years ago

Looks good thanks!

-Kevin and Riz