search

cloudfoundry-attic / consul-release

This is a BOSH release for consul.
Apache License 2.0
10 stars 30 forks source link

Make confab timeout configurable #78

Closed xtreme-jesse-malone closed 7 years ago

xtreme-jesse-malone commented 7 years ago

We have a large deployment (US-PWS) on which consul now takes approx. 1:20 to start and thus hits the timeout built into the consul-release. This pull request adds a property to configure the confab timeout on the consul_agent job. We didn't add these changes to the consul_agent_windows job because we don't have an environment handy for testing on windows. We tested the consul_agent changes on a bosh-lite environment.

cfdreddbot commented 7 years ago

Hey xtreme-jesse-malone!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 7 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/151557573

The labels on this github issue will be updated when the story is started.

mcwumbly commented 7 years ago

FYI, we decided to simplify the implementation a bit so the spec property is now simply confab.timeout_in_seconds and only accepts integer values.

The monit script subtracts 5 from that value, while the confab.json template simply passes it through.

This is included in consul-release v179.