Switched badge to concourse

cloudfoundry-attic / datadog-firehose-nozzle

OBSOLETE CF component to forward metrics from the Loggregator Firehose to DataDog

Apache License 2.0

9 stars 29 forks source link

Switched badge to concourse #14

Closed rothgar closed 8 years ago

rothgar commented 8 years ago

According to the Concourse documentation this fixes #13 but I swear the image won't load for me. The raw badge is located which also breaks in this comment so I can only think there's some reason github doesn't like the image URL without a .svg at the end. I'm going to open an issue for concourse since I saw other projects with broken badge images too.

cfdreddbot commented 8 years ago

Hey rothgar!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/131784501

The labels on this github issue will be updated when the story is started.

coveralls commented 8 years ago

Coverage remained the same at 92.683% when pulling 9bc2dae4138f5d0f91365721592026f97eb9c024 on rothgar:master into 6021ad3f693eab0e9d2c0b29e3c29b93346404c0 on cloudfoundry-incubator:master.

wfernandes commented 8 years ago

@rothgar Thanks for the PR. I believe its CORS issue. I would follow @AlphaT3ch's solution of using crossorigin.me as seen here

If you are really curious you can discuss with the concourse team at https://concourseci.slack.com/messages/general/

I'll merge your PR in as soon as I get confirmation that the CLA is signed.

coveralls commented 8 years ago

Coverage remained the same at 92.683% when pulling 996d3b396921c4d8a7fd13e8466a4fbfdb1ad510 on rothgar:master into 6021ad3f693eab0e9d2c0b29e3c29b93346404c0 on cloudfoundry-incubator:master.

cfdreddbot commented 8 years ago

Hey rothgar!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/131833817

The labels on this github issue will be updated when the story is started.

coveralls commented 8 years ago

Coverage remained the same at 92.683% when pulling 996d3b396921c4d8a7fd13e8466a4fbfdb1ad510 on rothgar:master into 6021ad3f693eab0e9d2c0b29e3c29b93346404c0 on cloudfoundry-incubator:master.

rothgar commented 8 years ago

I just emailed the CLA

cfdreddbot commented 8 years ago

Hey rothgar!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/132105235

The labels on this github issue will be updated when the story is started.

cfdreddbot commented 8 years ago

Hey rothgar!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

cf-gitbot commented 8 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/132105305

The labels on this github issue will be updated when the story is started.

coveralls commented 8 years ago

Coverage increased (+0.07%) to 92.749% when pulling 996d3b396921c4d8a7fd13e8466a4fbfdb1ad510 on rothgar:master into 6021ad3f693eab0e9d2c0b29e3c29b93346404c0 on cloudfoundry-incubator:master.