search

cloudfoundry-attic / eclipse-integration-cloudfoundry

Cloud Foundry Integration for Eclipse
Apache License 2.0
41 stars 47 forks source link

Upgrading version of tycho to 0.18.1 so that it works with maven 3.1+ #13

Closed Phanatic closed 10 years ago

Phanatic commented 10 years ago

With maven version 3.2.1, running mavn package =Pe37 returns a methodNotFound exception.

nierajsingh commented 10 years ago

Thanks for the PR. I'll test it and if all is good, merge it.

Phanatic commented 10 years ago

@nierajsingh, just checking up on the status of this PR. Is there an IRC channel on which the team communicates?

nierajsingh commented 10 years ago

Hi,

I've tested your PR locally, and CF Eclipse built fine. The PR is good for merging, but unfortunately I have to check on our updated policy for contribution agreements for PRs from individuals, as we are no longer on EPL licence. I hope to have an answer within a day or so, if I can accept the PR without a contribution agreement, or if I have to push the commit separately myself. Thanks for your patience, and I hope to have an answer very soon.

Also, we don't have an IRC channel for CF Eclipse. The closest is the two Cloud Foundry Google forum groups:

https://groups.google.com/a/cloudfoundry.org/forum/#!forum/cf-eclipse

and

https://groups.google.com/a/cloudfoundry.org/forum/#!forum/vcap-dev

vcap-dev gets far more traffic, but is more general for all of Cloud Foundry development.

Thanks.

nierajsingh commented 10 years ago

Hi,

I apologise for taking a while to address this PR, especially since it is a very small change. We had to update our CLA Agreement for individuals. The old one was still pointing to the Spring CLA which is no longer applicable as CF Eclipse is no longer a Spring project.

As a consequence, we require all individuals submitting pull requests, regardless of size or impact, to first sign the Pivotal Software Individual Contributor License Agreement:

http://blog.cloudfoundry.com/wp-content/static/cforg/pdfs/individualcontribution.pdf

Once you sign this I will be able to merge this and future PRs, and you'll get author credit for it. Alternately, if you are unable to sign the agreement, I can push the change myself.

Thanks again for the PR, and thanks for your patience and understanding.

Phanatic commented 10 years ago

Thanks for the info @nierajsingh, I'll check with my team and review the ICLA. I can sign the ICLA later this week and get started on contributing changes back to the project.

nierajsingh commented 10 years ago

Thanks very much. Here is the updated CLA, and it has two options, one for individuals and one for corporations:

https://github.com/cloudfoundry/eclipse-integration-cloudfoundry#contributing

Phanatic commented 10 years ago

@nierajsingh I've emailed the signed ICLA and will be snail mailing the hard copy later.

nierajsingh commented 10 years ago

Thanks very much for signing the contribution agreement. I'll merge and close this PR.