search

cloudfoundry-attic / eclipse-integration-cloudfoundry

Cloud Foundry Integration for Eclipse
Apache License 2.0
41 stars 47 forks source link

Fix a dnd problem introduced by commit caeee93 #14

Closed dengwa closed 10 years ago

dengwa commented 10 years ago

caeee93 introducted a condition check (modObj instanceof IProject). This causes failures when dragging java project from package explorer to application viewer.

In this case, the model of a Java Project in eclipse is an instance of IJavaProject, so the original code in line 192 of ApplicationMasterPart can't recognize the DragAndDrop of JavaProject to applicationsViewer.

The fix is to also check (modObj instanceof IJavaProject) and the way to get the module name.

nierajsingh commented 10 years ago

2514ac5 should fix the issue, although it can be improved by checking for IJavaProject rather than JavaProject. Please sync with cloudfoundry:master and see if the issue is resolved for you. Thanks.

huaweitechadm commented 10 years ago

Wonderful! we both noticed the problem and worked on the fix at almost the same time. Yes, your fix works the same.

nierajsingh commented 10 years ago

Thanks. I'll go ahead and close this PR.