Closed Phanatic closed 10 years ago
Thanks for submitting the PR. This is a far better solution that having an extension point. One thing I do want to mention before I accept the PR is that the console messages may change in the future. Although these are user visible text, it's part of internal core components of CF Eclipse so we may change them later. However, I think for the time being your changes are fine. Thanks again.
@nierajsingh, thanks for the insight into future changes in the messages. I'll keep an eye out for changes in this area.
@nierajsingh, can this be merged in?
It is a good idea to clean those messages up. A couple of thoughts:
Any thoughts?
I am leaning towards just making general statements.
"Pushing application" sounds fine as the application name is already mentioned when the console is started. The server name is already mentioned in the console view title, so I think we can skip mentioning the server name.
If we are all in agreement, maybe this PR can be modified to just remove "Cloud Foundry" from those messages for now and make the statements more general.
Thanks.
"Publishing application" sounds good to me given that the server and app name has already been mentioned.
Yep, I can make the messages more general across the board in the console and push a change later today.
Thanks, Phani
On Jul 24, 2014, at 9:25 AM, Elson Yuen notifications@github.com wrote:
"Publishing application" sounds good to me given that the server and app name has already been mentioned.
— Reply to this email directly or view it on GitHub.
Fixes #16. No new extension point is required, I was able to read the service name from the CloudFoundryBrandingExtensionPoint type and use NLS.bind to bind the service name to the messages.