search

cloudfoundry-attic / eclipse-integration-cloudfoundry

Cloud Foundry Integration for Eclipse
Apache License 2.0
41 stars 47 forks source link

Drag & Drop of web app opens the Deploy Application wizard twice #19

Closed Phanatic closed 7 years ago

Phanatic commented 10 years ago

When I drag and drop a web app onto the application & services window in a server's properties, the Deploy application wizard pops up twice. The plugin version I'm using is : Cloud Foundry Integration for Eclipse 1.7.0.201406182004-RELEASE

Here's a screenshot img

nierajsingh commented 10 years ago

Hi,

Thanks for noticing this issue. This only happens when you drag and drop onto the Cloud Foundry editor, in the "Applications" table? Do you get this issue if you deploy your application as "Run As -> Run On Server" context menu option from the Project Explorer or if you drag and drop it onto the Server instance in the Eclipse Servers view?

Does your application have dependent modules, or it's a simple Web application? Thanks.

Phanatic commented 10 years ago
  1. This only happens when you drag and drop onto the Cloud Foundry editor, in the "Applications" table? Yep, only on drag & drop
  2. Do you get this issue if you deploy your application as "Run As -> Run On Server" context menu option from the Project Explorer? No, in that case, only one wizard dialog is shown.
  3. Do you get this issue if you drag and drop it onto the Server instance in the Eclipse Servers view? Nope, I still get only one wizard dialog shown in that case too.
Phanatic commented 10 years ago

I think the issue lies in the ApplicationMasterPart.Java where we handle drag & drop, invoking the perform drag method on the super class, as we do here is causing the publish dialog to get invoked. And then when we call publishAdd, the dialog is being invoked again

nierajsingh commented 10 years ago

Thanks very much for the answers. I will notify when there is a fix available in the nightly build that can be used to test and close the issue.

Phanatic commented 10 years ago

BTW @neiraj, can you also please look at #18 & #17 ?