search

cloudfoundry-attic / eclipse-integration-cloudfoundry

Cloud Foundry Integration for Eclipse
Apache License 2.0
41 stars 47 forks source link

Mark in plugin.xml that CF does support remote hosts #2

Closed jkff closed 10 years ago

jkff commented 12 years ago

I've got a CloudFoundry installation of my own, but not on my local machine. I tried pointing STS to that installation in the "new server" dialog, selecting a Cloud Foundry server type, but got an error "The currently selected server type does not support remote hosts" when typing in its API URL (I configured it to api.vcap.me and added a /etc/hosts entry on my machine).

This commit fixes this issue by simply declaring that CF does support remote hosts in the plugin.xml server type entry. I made a build of the plugin and verified that thusly "added" remote host support is working correctly.

martinlippert commented 12 years ago

Great to see the first community contribution to this project. Thanks a lot for this, Eugene! Before we can commit this to the repo, I need to ask you to sign the contributors agreement here: https://support.springsource.com/spring_committer_signup I know, it might look a bit oversized for small contributions, but we need that for making sure that the open-source licenses are valid and in good shape all the time. Hope this works for you...

jkff commented 12 years ago

Thanks Martin. I signed the agreement, the confirmation number is 24320120412025131 . Do I need to provide any further info?

martinlippert commented 12 years ago

I think this regards to the contributor agreement, everything is in place now. Thanks a lot for quickly signing that agreement, that helps us a lot. With regards to your patch: What URL are you using now as your Cloud Foundry API URL? And how can I setup a similar setting to test your patch in more detail?

jkff commented 12 years ago

Hm. I was using api.vcap.me, but I was entering it in the "new server wizard" in place of "localhost" and then ALSO choosing it in the next wizard step (Account information => URL). Now that I re-read the documentation, it looks like I could just have left "localhost" as is in the first window, so I'm not sure this patch was really needed to accomplish my goal :-|

If this is indeed so, then I suggest to modify the new server wizard UI, because it's rather confusing this way:

martinlippert commented 12 years ago

I agree that the localhost field in the new server wizard doesn't make much sense, because you should just need to put in your Cloud Foundry URL in the second step and that's it. So I tend to disable or completely remove the localhost field in the first step and just have the second step for entering the URL. Can you test that in your setting whether this would work? (just ignoring the "localhost" value in the first wizard step and use api.vcap.me in the second one? It should have no effect on the CF communication, but it would be great if you could double-check this in your setting.

jkff commented 12 years ago

I'll check this a little later and report back, as at the moment my CF installation is offline.

martinlippert commented 12 years ago

Did you find the time to try this again?

nierajsingh commented 10 years ago

Host field is now disabled in CF 1.6.1