All the bound cloud applications are re-pushed if deleting one bound pro...

cloudfoundry-attic / eclipse-integration-cloudfoundry

Cloud Foundry Integration for Eclipse

Apache License 2.0

41 stars 47 forks source link

All the bound cloud applications are re-pushed if deleting one bound pro... #26

Open liuhewei opened 10 years ago

liuhewei commented 10 years ago

...ject

Phenomenon of the Bug:

During the process of deleting a bound project in Package Explorer, it will trigger all the other bound cloud applications to be re-pushed. The user can't do nothing except waiting all the re-pushing are finished.

issue8_triggerrepushboundcloudapplication

Effect of the Modifications:

The re-pushing still exists during the process of deleting bound project, but a confirmation dialog, which asks the user to determine whether to re-push or not, will be presented for each bound cloud application. By this way, the re-pushing can be interrupted and canceled by the dialog rather than be unbreakable.

issue8_repushconfirm

cfdreddbot commented 10 years ago

Hey liuhewei!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA.

nierajsingh commented 10 years ago

Hi,

Thanks for submitting this PR to prompt users whether to re-publish deployed applications when deleting another application.

Conceptually, we'd be in favour of feature like this when a user is deleting an application.

However, I tested the current PR, and it seems that the user gets prompted any time there is a change to the bound project and the user selects Server -> Publish in the Servers view, so the prompting is not limited to just deleting an application. It seems that prompting will appear on any Server -> Publish operation when there are changes in the bound/mapped project.

We'd like to find a way to restrict the prompting to just when performing an operation like delete, but not when doing Server -> Publish.

We'll see if there is another way to prompt users without affecting the current Server -> Publish operation, and follow up with our findings. Thanks.

liuhewei commented 10 years ago

@nierajsingh You're right, this feature hasn't been verified very well, sorry for that. We have modified the code to align with your suggestion: "restrict the prompting to just when performing an operation like delete, but not when doing Server -> Publish". Could you review it? Thanks.

nierajsingh commented 10 years ago

Hi,

We wanted to update on this PR. We're still currently working on alternative that would better handle issues with the server-wide publish of other applications when deleting only one application.

Although your solution does seem to work for delete cases, I think there is more general underlying problem with our existing code regarding how CloudFoundryServer modifies modules locally (i.e. add or delete) versus how the CloudFoundryServerBehaviour then publishes to the actual Cloud Foundry server through publish modules operation. I think if we address this appropriately it will also take care of your case where you don't want to see other applications re-published when deleting an application.

We do have this prioritised for 1.7.3, so we'll update this PR with a link to a github branch where you can test our suggested solution.

Thanks again for working on this problem.

liuhewei commented 10 years ago

@nierajsingh OK. Looking forward to your solution:)