cloudfoundry-attic / eclipse-integration-cloudfoundry

Cloud Foundry Integration for Eclipse
Apache License 2.0
41 stars 47 forks source link

Handle prompts data #35

Open dweber019 opened 9 years ago

dweber019 commented 9 years ago

Starting position: We have implemented an external authorization server (portal). So the portal provides the login information which also provides the prompts. The CF UAA functions for token handling only.

In the /login response from the portal asks for the following prompts: username, 2factor, password.

I have the same problem as here https://groups.google.com/a/cloudfoundry.org/forum/#!searchin/vcap-dev/eclipe/vcap-dev/btP9wybkg1E/uQd59Z8MPiAJ.

My questions: Are additional prompts properly handled? After a lot of analyses I think this is the problem.

cf-gitbot commented 9 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/88333504.

dweber019 commented 9 years ago

An other question regarding prompts. Do we need to provide a email address or can we use the username.

nierajsingh commented 9 years ago

At the moment we only handle prompting with username (for Pivotal Web Services, this would be the email) and password. Although the Eclipse UI states "email", there is no enforcement for using an email on the Eclipse side. It would depend on the target Cloud if it would accept only emails as usernames, or also usernames themselves.

Regarding login prompts, we've done some work accepting tokens from non-UAA/login at the cf-java-client level, but we do not have a prompt UI for it at the Eclipse level yet. Here is a related PR for that:

https://github.com/cloudfoundry/cf-java-client/pull/259

If this would work for you, meaning that you could pass in a token via the UI when prompting for credentials, we can create a feature request for it.

If you have other suggestions for handling your case on the Eclipse side, please let us know.

dweber019 commented 9 years ago

Is there the possibility to build the Login UI according to the prompts provided from the login info response?

nierajsingh commented 9 years ago

Hi,

We'll look into whether we can generate the login UI based on the login info. We are not sure if we can but we'll look at this for post-1.8.2 release of the plugin after the end of March. Thanks for your patience.