search

cloudfoundry-attic / eclipse-integration-cloudfoundry

Cloud Foundry Integration for Eclipse
Apache License 2.0
41 stars 47 forks source link

Proxy configuration : nonProxyHosts support #48

Closed axel3rd closed 5 years ago

axel3rd commented 9 years ago

Hi,

Currently the v1.8.2 doesn't support the nonProxyHosts network configuration. Mainly because CloudFoundryClientFactory.getProxy() applies the proxy only if activated and protocol found.

Impacts : When you are using an intranet CF, you need to switch to the Direct network provider for every CF function. It is boring ;-).

This PR provides the usage of IProxyService.select(URI uri), doing the job for us.

NB : I can't sign individuals / corporations , links broken, sorry. Best regards.

cfdreddbot commented 9 years ago

Hey axel3rd!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

cf-gitbot commented 9 years ago

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/103695350.

nierajsingh commented 9 years ago

Hi,

Thanks for the PR. We are in the process of switching to Eclipse project, and Cloud Foundry Eclipse, now called Eclipse Tools for Cloud Foundry under Eclipse Cloud Development, will be governed by Eclipse CLA.

We will update this github page with new information as we move forward with the transition.

Eventually, we will also change repositories, but for the time being we'll continue committing to this github repository.

The new Eclipse page for the Eclipse Tools for Cloud Foundry is:

https://projects.eclipse.org/projects/ecd.cft

We'll take a look at your PR and test it, but unfortunately we have to wait until we transition to Eclipse project.

As part of transitioning to Eclipse project, the current tools are being renamed to comply with Eclipse naming conventions. Consequently, the new version of the tools will not be backward compatible and also will require this PR to be modified.

We apologise for any inconvenience this may cause.

However, the move to Eclipse project will increase exposure to these tools, and bring greater enhancements.

Thank you for your understanding, and once we make the changes we'll request if you can re-submit the PR again to use the new code base.

axel3rd commented 9 years ago

@nierajsingh : OK no problem I will wait the new CLA policy.

Remarks :

axel3rd commented 9 years ago

ITs not updated ... I just have done site ZIP for real tests

ITs run and OK with Maven.

I will try to add a specific IT for nonProxyHosts case, but currently I have this error under Eclipse (Kepler SR2) ...

java.lang.NullPointerException
    at org.eclipse.wst.server.core.ServerCore.loadServerTypes(ServerCore.java:235)
    at org.eclipse.wst.server.core.ServerCore.findServerType(ServerCore.java:171)
    at org.cloudfoundry.ide.eclipse.server.ui.internal.ServerHandler.createServer(ServerHandler.java:148)
    at org.cloudfoundry.ide.eclipse.server.ui.internal.ServerHandler.createServer(ServerHandler.java:140)
    at org.cloudfoundry.ide.eclipse.server.tests.util.CloudFoundryTestFixture$Harness.createServer(CloudFoundryTestFixture.java:189)
    at org.cloudfoundry.ide.eclipse.server.core.internal.AbstractCloudFoundryTest.setUp(AbstractCloudFoundryTest.java:105)
axel3rd commented 8 years ago

Switch to Eclipse CFT bugtracker.