search

cloudfoundry-attic / vcap-yeti

Cloud Foundry - the open platform as a service project
Apache License 2.0
15 stars 31 forks source link

missing rb-readline gem breaks test execution #12

Closed grenzr closed 11 years ago

grenzr commented 11 years ago

During bundler execution of rspec, results in:

var/lib/jenkins/.rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/bundler/gems/cf-722e233a782d/lib/console/console.rb:2:in `require': cannot load such file -- readline (LoadError)
    from /var/lib/jenkins/.rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/bundler/gems/cf-722e233a782d/lib/console/console.rb:2:in `<top (required)>'
    from /var/lib/jenkins/jobs/vcap-yeti/workspace/lib/harness/console_helper.rb:1:in `require'
    from /var/lib/jenkins/jobs/vcap-yeti/workspace/lib/harness/console_helper.rb:1:in `<top (required)>'
    from /var/lib/jenkins/jobs/vcap-yeti/workspace/lib/harness.rb:47:in `require'
    from /var/lib/jenkins/jobs/vcap-yeti/workspace/lib/harness.rb:47:in `<top (required)>'
    from /var/lib/jenkins/jobs/vcap-yeti/workspace/spec/apps/async_staging_spec.rb:1:in `require'
    from /var/lib/jenkins/jobs/vcap-yeti/workspace/spec/apps/async_staging_spec.rb:1:in `<top (required)>'
    from /var/lib/jenkins/.rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/rspec-core-2.14.5/lib/rspec/core/configuration.rb:896:in `load'
    from /var/lib/jenkins/.rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/rspec-core-2.14.5/lib/rspec/core/configuration.rb:896:in `block in load_spec_files'
    from /var/lib/jenkins/.rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/rspec-core-2.14.5/lib/rspec/core/configuration.rb:896:in `each'
    from /var/lib/jenkins/.rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/rspec-core-2.14.5/lib/rspec/core/configuration.rb:896:in `load_spec_files'
    from /var/lib/jenkins/.rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/rspec-core-2.14.5/lib/rspec/core/command_line.rb:22:in `run'
    from /var/lib/jenkins/.rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/rspec-core-2.14.5/lib/rspec/core/runner.rb:80:in `run'
    from /var/lib/jenkins/.rbenv/versions/1.9.3-p448/lib/ruby/gems/1.9.1/gems/rspec-core-2.14.5/lib/rspec/core/runner.rb:17:in `block in autorun'
mark-rushakoff commented 11 years ago

Hi @grenzr, thanks for spotting this! @matthewmcnew and I spent a little time investigating this error. It turns out that most systems (e.g. all of our development machines) have Readline installed as part of the standard library, but some (e.g. your Jenkins box) do not.

The top line of the stack trace that you posted indicates that the failing line is actually in the cf gem. So while we can fix this problem in vcap-yeti, that won't solve the problem for the next person using cf without readline. In other words, this problem should be fixed in cf rather than in vcap-yeti.

Also, it seems a little strange to require the ruby implementation of readline when most systems do have Readline available. So rather than adding gem "rb-readline" to the Gemfile, I would lean towards changing require "readline" in console.rb to something like:

begin
  require "readline"
rescue LoadError
  warn "This version of Ruby was not compiled with Readline support. Falling back to a pure Ruby implementation."
  require "rb-readline"
end

I'm closing this issue, but please open a pull request against cf and reference this issue -- unfortunately GitHub doesn't have a way to simply move issues from one repo to another :(