search

cloudfoundry-attic / vcap-yeti

Cloud Foundry - the open platform as a service project
Apache License 2.0
15 stars 31 forks source link

Switch to latest, vanilla Heroku nodjs buildpack breaks yeti tests for Node #16

Closed andrewlow closed 10 years ago

andrewlow commented 10 years ago

The file spec/apps/node_spec.rb needs to be revised.

The latest buildpack from heroku doesn't support Node 0.6 anymore. This is because semver.io gives this answer: https://semver.io/node/resolve/0.6.x -> 0.10.24

I've reported this as an issue against node-version-resolver https://github.com/heroku/node-version-resolver/issues/1

For some reason the Node 0.10.24 version and bcrypt seem to be cranky. I haven't dug enough into this, it may be some other issue. Don't be surprised if you hit problems here. I found that 0.10.21 worked fine, but need to see if it's a specific 0.10.24 problem, or my environment.

The last issue is that the 'old' buildpack installs semver along side of node. The new one does not. So the node_spec.rb code above, it looks for semver as a 'git module', and fails with the new buildpack.

dbailey commented 10 years ago

@MarkKropf are we supporting the vcap-yetis anymore?

MarkKropf commented 10 years ago

@andrewlow @dbailey We've gotten ahead of ourselves and have already stopped contributing to vcap-yetis prior to moving cats out of experimental. I'll be prioritizing stories to get cats moved over to the cloud foundry org and to formally deprecate the yetis.

All of our nodejs tests are currently using cats: https://github.com/pivotal-cf-experimental/cf-acceptance-tests

andrewlow commented 10 years ago

@MarkKropf thanks for taking time to look at this.