search

cloudfoundry-community-attic / bosh-cloudfoundry

Create, scale and upgrade your company's own Cloud Foundry
https://github.com/cloudfoundry-community/bosh-cloudfoundry#readme
MIT License
90 stars 29 forks source link

Sync nfs mount point with CF release 146 #260

Closed nicregez closed 10 years ago

trastle commented 10 years ago

This is a good change, as it will work with CF146.

However, is there a need to specify this property at all? If left out (as seems to be the pivotal recommendation) there is no ill effect and it will work with < 146 as well as >=146

There is a VCAP-DEV discussion about this here: https://groups.google.com/a/cloudfoundry.org/d/msg/vcap-dev/IqMCuSzEDFs/hYO11GPWMpYJ

T.

drnic commented 10 years ago

Troy, if it can be removed then can you submit a PR to remove it?

On Tue, Nov 5, 2013 at 10:21 AM, trastle notifications@github.com wrote:

This is a good change, as it will work with CF146. However, is there a need to specify this property at all? If left out (as seems to be the pivotal recommendation) there is no ill effect and it will work with < 146 as well as >=146 There is a VCAP-DEV discussion about this here: https://groups.google.com/a/cloudfoundry.org/d/msg/vcap-dev/IqMCuSzEDFs/hYO11GPWMpYJ

T.

Reply to this email directly or view it on GitHub: https://github.com/cloudfoundry-community/bosh-cloudfoundry/pull/260#issuecomment-27798289

trastle commented 10 years ago

@drnic Done. https://github.com/cloudfoundry-community/bosh-cloudfoundry/pull/262

nicregez commented 10 years ago

This pull request is obsoleted by #262.

drnic commented 10 years ago

Thanks everyone!

On Wed, Nov 6, 2013 at 11:28 PM, nicregez notifications@github.com wrote:

Closed #260.

Reply to this email directly or view it on GitHub: https://github.com/cloudfoundry-community/bosh-cloudfoundry/pull/260