search

cloudfoundry-community / autosleep

Auto sleep service for CloudFoundry
Apache License 2.0
39 stars 21 forks source link

Introduce enrolled_organization_config table and model #267

Closed pradyutsarma closed 7 years ago

pradyutsarma commented 7 years ago
  1. Story details https://www.pivotaltracker.com/story/show/134541301
  2. There will be some refactoring to the model with the REST APIs PR and the transient mode support
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.01%) to 94.987% when pulling c77d31fa06d561e012ac1d58de561502fd7fa177 on pradyutsarma:feature_org_config_db into 7e249c3d03e0c6c002eb40e03c1bd309ca67a76f on cloudfoundry-community:develop.

gberche-orange commented 7 years ago

thanks @pradyutsarma for this PR. Sorry again for the slow merge. I hope to find time to review in details and merge soon.

pradyutsarma commented 7 years ago

No problem @gberche-orange . I understand.

gberche-orange commented 7 years ago

thanks @pradyutsarma for the additional comments. Please have a look at commits from https://github.com/orange-cloudfoundry/autosleep/tree/feature_org_config_db_GB_refinements if this can help

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 94.994% when pulling f6bdd03664391f67ce1c5765f2de083c4810e715 on pradyutsarma:feature_org_config_db into 7e249c3d03e0c6c002eb40e03c1bd309ca67a76f on cloudfoundry-community:develop.

pradyutsarma commented 7 years ago

Detailed unit tests for the model parameters will follow in the next PR along with the REST APIs. Hence, did not include them in this. Also, kept the autoEnrollment parameter as it is instead of defaultAutoEnrollment since it's self explanatory as the default value for 'this' org.

pradyutsarma commented 7 years ago

Closing this PR without merge. Will create another PR including the changes from this and additional REST APIs for org enrollment support.