Feature restapis

[pradyutsarma]

1. Introduce the org_enrollment_config table and model
2. Backoffice REST APIs to enrol, update and delete org enrollment parameters
3. Unit tests

[coveralls]

Coverage increased (+0.06%) to 95.034% when pulling f00b8c3071e2738b79edf04ef0361abd8d2d49e0 on pradyutsarma:feature_restapis into 7e249c3d03e0c6c002eb40e03c1bd309ca67a76f on cloudfoundry-community:develop.

[pradyutsarma]

Thanks for the detailed feedback @gberche-orange. I have provided my comments inline. >>recommend to integrate the suggested unit tests for the OrgEnrollment model Yes. I will update the PR with the tests.

>> The PR seems to lack reading default values from environment variables specified at autosleep deployment time As outlined in the my comments above, this PR only introduces the REST APIs and validates the user input. The usage of the values (and the defaults in their absence) will be done by the poller which will be submitted next which actually does will create (or update) the service instances in the necessary spaces.

Swagger APIs I would like to provide this in a separate PR. Not really comfortable with one PR handling too many things. Created a story for this https://www.pivotaltracker.com/story/show/136915897. Will submit on priority.

[gberche-orange]

Thanks @pradyutsarma for the additional precision on the PR. Besides other comments in this PR:

The PR seems to lack reading default values from environment variables specified at autosleep deployment time As outlined in the my comments above, this PR only introduces the REST APIs and validates the user input. The usage of the values (and the defaults in their absence) will be done by the poller which will be submitted next which actually does will create (or update) the service instances in the necessary spaces.

Agreed, thanks.

Swagger APIs I would like to provide this in a separate PR. Not really comfortable with one PR handling too many things. Created a story for this https://www.pivotaltracker.com/story/show/136915897. Will submit on priority.

Thanks.

[coveralls]

Coverage increased (+0.08%) to 95.051% when pulling fa7d47dbc3f0f19c772bb71f1a6c78b4d03e3b92 on pradyutsarma:feature_restapis into 7e249c3d03e0c6c002eb40e03c1bd309ca67a76f on cloudfoundry-community:develop.

[coveralls]

Coverage increased (+0.08%) to 95.051% when pulling b17d438ef5fc4f8d603c6de2ad3faba02993c203 on pradyutsarma:feature_restapis into 7e249c3d03e0c6c002eb40e03c1bd309ca67a76f on cloudfoundry-community:develop.

[coveralls]

Coverage decreased (-0.1%) to 94.831% when pulling 20cc4c536b386777974ee2844ea9103386189309 on pradyutsarma:feature_restapis into 7e249c3d03e0c6c002eb40e03c1bd309ca67a76f on cloudfoundry-community:develop.

[pradyutsarma]

I'm sorry @gberche-orange but the PR got polluted by the code from the rebased commits. I'm hoping you will be able to review the new changes.

[coveralls]

Coverage increased (+0.08%) to 95.056% when pulling 77f9079916ea24a0ee358b408afa18f8174056bf on pradyutsarma:feature_restapis into 7e249c3d03e0c6c002eb40e03c1bd309ca67a76f on cloudfoundry-community:develop.

[gberche-orange]

@pradyutsarma I might have to squash your commits to remove the unintended merge of the guerkins-related commits. This will have the side effect of having the commit misleading attributed to my self instead of you. If this is of importance to you, you might want to prefer to do the squashing yourself (if needed this resource might provide some background on how to do this).

I'll however try the local merge and see if guerkins commit conflicts, and will report soon.

[gberche-orange]

Thanks @pradyutsarma for this contribution and the exchange over the phone. Finally, no need to squash.

We agreed to review the validation aspect in a different story with:

• consider having time.Duration or Pattern object in Request object and leave jackson perform the conversion by itself (see https://github.com/FasterXML/jackson-modules-java8/blob/master/datetime/src/test/java/com/fasterxml/jackson/datatype/jsr310/TestDurationDeserialization.java)
• investigate ways to collect all violations from jsr310 to return them in the API response.

[pradyutsarma]

@gberche-orange Created a story to evaluate this https://www.pivotaltracker.com/story/show/138842963