search

cloudfoundry-community / autosleep

Auto sleep service for CloudFoundry
Apache License 2.0
39 stars 21 forks source link

Dot characters supported for cf set-env #270

Closed drnic closed 6 years ago

drnic commented 7 years ago

I ran cf set-env autosleep-app cf.service.broker.name autosleep-starkandwayne successfully (prior to reading this warning that it wouldn't work). I believe we can remove this warning.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 91.333% when pulling d9801ffc51176e0a25abc1c91defb422be53f291 on dot-characters into d3fe6db5159997184f96dce03dd4711b692e0774 on master.

gberche-orange commented 7 years ago

Thanks @drnic

The Linux shell do not support dots in environment variables names``

$export a.b=c bash: export:a.b=c': not a valid identifier ``

Diego however manages to assign such environment variables to the LRP process, unlike DEA (see https://github.com/cloudfoundry/dea_ng/issues/197)

We'll have to get a confirmation from the diego/garden teams that there is a long term commitment to support any environment variables names, even the ones not supported by Linux shells, before recommending users to use such syntax.