Adopt to latest cf-java-client and adapt requisite apis

cloudfoundry-community / autosleep

Auto sleep service for CloudFoundry

Apache License 2.0

39 stars 21 forks source link

Adopt to latest cf-java-client and adapt requisite apis #287

Closed pradyutsarma closed 6 years ago

pradyutsarma commented 6 years ago

@gberche-orange I'm guessing I missed the mandated null checks with the latest java client release. Just to be sure, can you share the findbugs report from the travis build? I don't know how to access it within the build.

gberche-orange commented 6 years ago

@pradyutsarma Thanks for the PR. I'm out of office until Jan 8th. I don't believe travis stores the intermediate reports. You might have to reproduce locally instead.

coveralls commented 6 years ago

Coverage remained the same at 95.127% when pulling b2edc24fe751c835dc552462ee4f8d6c7c8890d6 on pradyutsarma:cf-client-update into 38aa4aafe75812790d3a75bcfe70d260b3d399b4 on cloudfoundry-community:develop.

pradyutsarma commented 6 years ago

No problem @gberche-orange. The build's green now. You can review and merge once you're back from vacation. This PR should fix https://github.com/cloudfoundry-community/autosleep/issues/285 and https://github.com/cloudfoundry-community/autosleep/issues/283

gberche-orange commented 6 years ago

thanks @pradyutsarma

I ran the acceptance tests (after upgrading them), and completed the autowakeup with manual tests against a CF version 281.

I'll push associated additional commits to the develop branch (acceptance tests + logs)