search

cloudfoundry-community / autosleep

Auto sleep service for CloudFoundry
Apache License 2.0
39 stars 21 forks source link

Updated gradle.properties to liquibaseCoreVersion = 3.5.5 #291

Closed macevil closed 6 years ago

macevil commented 6 years ago

fix Issue #290

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 95.133% when pulling 2026d0da12187da997eeb3e23cbc9a87e40eef8a on macevil:develop into 441f4b4268269c7c1eda2e587ba12a85867c2d77 on cloudfoundry-community:develop.

pradyutsarma commented 6 years ago

The fix looks ok. But do you think we need to update our travis build to also run against pg 9.1 or is it to much of an overhead. @gberche-orange, ??

gberche-orange commented 6 years ago

@pradyutsarma sorry for late response. According to travis-ci documentation the default postgresql version used is 9.1.

The travis log files for this PR's build however indicate postgresql 9.2 was started:

[0K$ sudo service postgresql start
 * Starting PostgreSQL 9.2 database server

I'm not sure why the travis build did not previously detected this bug, as logs indicate the postgresql test were run and passed (same for logs associated with build a previous PR running pg 9.1 )

org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_delete_by_entity PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_find_one_returns_null_on_non_existing_id PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_delete_by_id PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_findall_no_filter PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_multiple_inserts PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_exists PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_insert PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_delete_in_mass PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_findall_filtered PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_empty_database_has_count_0 PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_delete_all PASSED
org.cloudfoundry.autosleep.access.dao.repositories.jpa.PostgresqlSpaceEnrollerConfigRepositoryTest > test_find_one_preserve_equality PASSED

anyway, merging this PR, thanks @macevil and sorry for late response.