search

cloudfoundry-community / cf-resource

Concourse resource for interacting with Cloud Foundry
Apache License 2.0
35 stars 63 forks source link

current_app_name behavior loses environment variables #60

Open sartan opened 6 years ago

sartan commented 6 years ago

When the zero-downtime deployment is triggered by the current_app_name property, it does not transfer over the environment variables that were set on the currently deployed app. This results in loss of any environment variables which were set via cf set-env rather than by the manifest or pipeline.

One could say that this is by design, however it runs counter to the cf push behavior, which maintains any currently set environment variables that are not present in the manifest.

kdvolder commented 5 years ago

One could say that this is by design

If it is then it seems odd. Why would rolling deployments not keep the env vars, whereas non-rolling deployments do. If it is 'by design' it would seem more logical to have both cases work the same way.