search

cloudfoundry-community / cf-resource

Concourse resource for interacting with Cloud Foundry
Apache License 2.0
35 stars 63 forks source link

Support native CF rolling app deployments in cf-resource #78

Open ericpromislow opened 5 years ago

ericpromislow commented 5 years ago

Note that when the use_rolling_app_deployment parameter is specified, path must be specified as well (this is documented in the README).

This feature is now part of the cloud controller and is accessible through version 6.44 of the CLI. At some point it should be feasible to remove the zdt package from this resource.

See: https://docs.cloudfoundry.org/devguide/deploy-apps/rolling-deploy.html

#165368744

Co-authored-by: Mona Mohebbi mmohebbi@pivotal.io Co-authored-by: Eric Promislow eric.promislow@suse.com Co-authored-by: Tim Downey tdowney@pivotal.io Co-authored-by: Connor Braa cbraa@pivotal.io

vito commented 5 years ago

:eyes: I see lots of pivotal.io emails there - is this PR coming from a CF team by any chance? We've been trying to find new ownership of this resource as Concourse team really doesn't have the bandwidth or expertise to support this as one of our "core resources". The BOSH deployment resource, for example, is now maintained by CF at https://github.com/cloudfoundry/bosh-deployment-resource

It'd be nice if a new fork could be created that leverages this behavior by default, and we could deprecate our cf resource just like we deprecated our bosh-deployment resource.

tcdowney commented 5 years ago

@vito is the bosh-deployment-resource actually maintained by CF (as in a team is responsible for it) or is it maintained by @drich10 as a side-project and he happens to be involved with CF?

You're correct that this came from the CF CAPI team, but we don't actually have much involvement with this resource apart from we discovered it existed and wanted to get our cool new feature in. 🙂

It'd be nice if a new fork could be created that leverages this behavior by default, and we could deprecate our cf resource just like we deprecated our bosh-deployment resource.

This could be interesting, but something we'd have to think about as a team. Cause we too are lacking in bandwith and although we have CF expertise we lack Concourse expertise!

ericpromislow commented 5 years ago

Hi @vito Yup, this PR is from the CF CAPI team. @tcdowney should we fork this somewhere then?

tcdowney commented 5 years ago

@ericpromislow

should we fork this somewhere then?

We'll need to have a team discussion aboutif this is something we both want to and have the bandwidth to take on. In general, though, there's some bureaucracy involved around getting a repo made and what org (eg @cloudfoundry vs @cloudfoundry-incubator) it would belong in.

This will all take some time to figure out, so I don't think we need to do anything immediately.

@vito are you opposed to working with us on getting this merged to the current resource?

vito commented 5 years ago

@tcdowney Fair, I'm not really sure if there's an official CF entity that keeps it going.

Maybe we could transfer this to cloudfoundry-community? :thinking: They seem to have a pattern for this sort of thing already, e.g. the bosh-config resource which is pushed to Docker Hub under a cfcommunity organization.

Having it live in that org would make it more obvious that it's not necessarily a fully-supported/maintained project and is more reliant on the overall community for upkeep and decision-making. I'm not sure if we'd still need to find a de-facto owner/maintainer, though. No idea how push access is moderated there.

I'd like to hold off on merging this until we figure that out, if it's OK with you. :slightly_smiling_face:

cwlbraa commented 5 years ago

@vito does concourse do CI/CD for this resource atm?

vito commented 5 years ago

@cwlbraa Yep: https://ci.concourse-ci.org/teams/resources/pipelines/cf

cwlbraa commented 5 years ago

After we hypothetically fork it to cf-community, if we could steal a concourse team member for part of a day to help move the CI into CAPI's concourse instance that'd be 👌and would save everybody a ton of now-and-future effort. That pipeline structure looks pretty different from ours and the PR resource is also unfamiliar to us.

DanielJonesEB commented 5 years ago

Hey all, what's the progress with moving this to cloudfoundry-community? We're on a gig where this feature would be useful, to avoid routes-that-were-added-after-the-first-deploy from disappearing.

vito commented 4 years ago

@cwlbraa @DanielJonesEB Sorry, dropped the ball on this. If there's still interest in moving it over just let me know where to transfer it to! We'd be happy to pair to make the hand-off go smoothly. :+1:

DanielJonesEB commented 4 years ago

Cheers @vito - I'll email the CFF folks and find out how we make that happen.

vito commented 4 years ago

The repo is moved! 🎊 @cwlbraa @tcdowney I've added you both as owners in a new cf-resource-maintainers team and made that team admin for this repo. Let me know if/when you want to pair and we can figure out how to hand-off the CI stuff and any other context necessary! I've synced with the team on this and we're good to go whenever. 👍 Sorry for the long delay and hopefully the situation hasn't completely changed since then. 😅