overwrite certs_secret if it already exists

cloudfoundry-community / eirini-bosh-release

A BOSH release for Eirini.

Apache License 2.0

4 stars 13 forks source link

overwrite certs_secret if it already exists #61

Closed phil9909 closed 5 years ago

phil9909 commented 5 years ago

The script in run.erb will not update the certs_secret if it already exists. We use the --dry-run feature of kubectl to generate a json and apply it afterwards, which will work for create and update scenario.

BTW: maybe it would be a good idea to also activate errexit (set -e) and/or similar options.

phil9909 commented 5 years ago

Looks good to me, thanks! I've just hooked our CI to have full tests on each PR, do you mind rebasing?

done