Do we really need cf_ignored_app=false in messages?

cloudfoundry-community / firehose-to-syslog

Send firehose events from Cloud Foundry to syslog.

MIT License

44 stars 58 forks source link

Do we really need cf_ignored_app=false in messages? #137

Closed hannayurkevich closed 6 years ago

hannayurkevich commented 7 years ago

Recently a new field cf_ignored_app was introduced (see https://github.com/cloudfoundry-community/firehose-to-syslog/issues/132).

I have a question. Can we omit "cf_ignored_app": "false" field for not-ignored applications when writing a message to syslog? This looks like a redundant info, but I'm not sure if is ok to omit it from implementation point of view.

shinji62 commented 7 years ago

Agree that's not really convenient. But this need a little bit of refactoring.

I will try to work on that when I have some time.

Thanks

hannayurkevich commented 7 years ago

Sure. Thank you!

shinji62 commented 6 years ago

Done in 4.1.1