separate extra fields from event payload, to allow adding it as "fiel…

cloudfoundry-community / firehose-to-syslog

Send firehose events from Cloud Foundry to syslog.

MIT License

44 stars 58 forks source link

separate extra fields from event payload, to allow adding it as "fiel… #151

Closed psychickita closed 7 years ago

psychickita commented 7 years ago

…ds" metadata

shinji62 commented 7 years ago

@psychickita First don't send a PR without explaining it. Sorry but firehose-to-syslog is not SPLUNK related or not ... If you are going to add splunk related things this, should be done in the splunk nozzle not in the firehose-to-syslog one.

psychickita commented 7 years ago

Apologies for not explaining better: our nozzle relies on syslog code and I did not want to duplicate code or effort. It seems reasonable that metadata fields may into a dedicated section of a payload, rather than just into the raw event itself. If that does not make sense, any thoughts on having a library for different nozzles to use, so that similar code is not floating around in multiple variations?