search

cloudfoundry-community / firehose-to-syslog

Send firehose events from Cloud Foundry to syslog.
MIT License
44 stars 58 forks source link

F2S_DISABLE_LOGGING works only when it sets as application env variable #184

Open muthu-aa opened 6 years ago

muthu-aa commented 6 years ago

We are trying to deny access to all applications to the logging services except when they opt in using F2S_DISABLE_LOGGING=false in the application manifest file. so as a platform operator, I have set the running and staging variable group as cf srevg '{"F2S_DISABLE_LOGGING":"true"}' and cf ssevg '{"F2S_DISABLE_LOGGING":"true"}' for the all applications. but it seems that the firehose-to-syslog doesn't check these variable groups to opt out apps.

Is there anyway this could be implemented by checking the variable groups and over riding them if it is passed in user provided env?

shinji62 commented 6 years ago

F2S_DISABLE_LOGGING works only when it sets as application env variable that the expected behavior.

For revg this need to be implement.