cloudfoundry-community / logsearch-boshrelease

A BOSH-scalable ELK release
Apache License 2.0
45 stars 49 forks source link

Add post-start check for logstash ingestors using syslog. #151

Closed bengerman13 closed 4 years ago

bengerman13 commented 5 years ago

We're using these post-checks essentially to fail a deployment if it leaves the cluster in a bad state, and thought others might like to make use of them. We have them defaulted to on, but I'd be happy to reverse the default if that helps get this merged.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

bengerman13 commented 5 years ago

I signed the CLA, but it still shows as needing to be signed. Does that mean @wjwoodson needs to sign it, too?

bengerman13 commented 5 years ago

@wjwoodson I think we confirmed in another PR that the issue here is we need you to sign the CLA if you're willing.

axelaris commented 4 years ago

Hi @bengerman13, thank you for contribution! Could you please check my comments in the code?

bengerman13 commented 4 years ago

Thanks for looking @axelaris. I responded to one of the comments.

I think we're stuck until @wjwoodson can sign the CLA, so no rush here :)

axelaris commented 4 years ago

We disabled CLA eventually, so no worries. Could you please also rebase your PR to include bpm?

siennathesane commented 4 years ago

@bengerman13 bump

axelaris commented 4 years ago

LGTM

axelaris commented 4 years ago

Thank you @bengerman13 !