Closed bengerman13 closed 4 years ago
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
I signed the CLA, but it still shows as needing to be signed. Does that mean @wjwoodson needs to sign it, too?
@wjwoodson I think we confirmed in another PR that the issue here is we need you to sign the CLA if you're willing.
Hi @bengerman13, thank you for contribution! Could you please check my comments in the code?
Thanks for looking @axelaris. I responded to one of the comments.
I think we're stuck until @wjwoodson can sign the CLA, so no rush here :)
We disabled CLA eventually, so no worries. Could you please also rebase your PR to include bpm?
@bengerman13 bump
LGTM
Thank you @bengerman13 !
We're using these post-checks essentially to fail a deployment if it leaves the cluster in a bad state, and thought others might like to make use of them. We have them defaulted to on, but I'd be happy to reverse the default if that helps get this merged.