Fix integration tests and revert bad changes

cloudfoundry-community / logsearch-for-cloudfoundry

A Logsearch addon that customises Logsearch to work with Cloud Foundry data

Apache License 2.0

49 stars 58 forks source link

Fix integration tests and revert bad changes #292

Closed bandesz closed 6 years ago

bandesz commented 6 years ago

Previously I submitted 6 PRs which were all merged without a question, but as it turns out the automated tests weren't running for these PRs and you merged them without knowing that these broke the integration tests.

We only ran the unit tests before submitting the PRs.

This PR:

reverts #286 (alter.coalesce is better to use there, it seems that one is not so trivial to replace)
fixes the integration tests for #287
fixes #290 which broke the JSON parsing for some fields

Infra-Red commented 6 years ago

@bandesz Thanks for submitting PR! Just one question, in previous PR you mentioned that now we can avoid usage of additional logstash plugins, maybe we can purge additional logstash plugins from logsearch-boshrelease repo? https://github.com/cloudfoundry-community/logsearch-boshrelease/blob/develop/packages/logstash/spec#L9-L12

bandesz commented 6 years ago

@Infra-Red I couldn't replace the alter.coalesce functionality with a simple solution, so we'll still need it.

bandesz commented 6 years ago

@Infra-Red the translate filter plugin and the syslog input plugin seems to be bundled by default in the latest Logstash version, so you might be able to remove those dependencies in the future.

Infra-Red commented 6 years ago

Thanks @bandesz !