CLAassistant
commented
6 years ago
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.
:x: sharms
:x: timothy-spencer
You have signed the CLA already but the status is still pending? Let us recheck it.
axelaris
This is a set of changes that worked for us to get ES6 going. The biggest issues that I found were: 1) Document types. These went away in ES6, so the index mappings and a lot of other things had to be rejiggered to handle this. 2) String type. These also went away, so they needed to be rewritten to be text and keyword types. 3) Kibana bulk import of dashboards/etc. This was largely undocumented, so I had to kind of reverse engineer this by doing a lot of staring at .kibana queries.
It definitely is not perfect, but it is a step in the right direction, and it works, so maybe you would be able to crib from this when you are able to do a more comprehensive upgrade. Here are the caveats that you should be aware of: 1) There is still a lot of document type related code floating around. None of it seems to affect what we are doing, but it worries me, because it creates the potential for landmines. I just changed what was needed to get it going. 2) I did not adjust documentation at all. Again, just got it working. 3) I did work in https://github.com/18F/logsearch-boshrelease/pull/6 at the same time, so if they can be used standalone at all, they may not actually stand on their own at all because I never tried that out.