search

cloudfoundry-community / logsearch-for-cloudfoundry

A Logsearch addon that customises Logsearch to work with Cloud Foundry data
Apache License 2.0
49 stars 58 forks source link

Use Kibana Saved Objects API #319

Closed Infra-Red closed 5 years ago

Infra-Red commented 5 years ago
  1. Update saved objects format to support Kibana API.
  2. Add a task to import saved objects to Kibana API.

Please first merge https://github.com/cloudfoundry-community/logsearch-boshrelease/pull/140

Fixes https://github.com/cloudfoundry-community/logsearch-for-cloudfoundry/issues/318

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

vetin4ri commented 5 years ago

@Infra-Red Thats great you have fixed the problem, but when I look at the change:

https://github.com/cloudfoundry-community/logsearch-for-cloudfoundry/pull/319/commits/8642c7f8584377ed6a692e75063b74b771397380

it seems like instead of using elastichserch.host you are using now CF_SYSTEM_DOMAIN. This means the job cannot be used anymore when Kibana is not installed as a CF app. Is this required from now on, or there was another reason for the change?

Infra-Red commented 5 years ago

Hey @vetin4ri! Is your Kibana instance accessible via CF route? Usually it’s should be available at logs.CF_SYSTEM_DOMAIN.

vetin4ri commented 5 years ago

Hi @Infra-Red, not really, we are using a setup where ELK is not associated with specific CF installation, but can handle logs deployments, including Kubernetes. It is not accessible via CF route nor installed on CF, but also in a separate network.

We were using upload-kibana-objects as it was loosely coupled with other jobs and could be easily used on its own.